[PATCH] D36495: [llvm] Get rid of "%T" expansions

[Kuba (Brecka) Mracek via Phabricator via llvm-commits]

kubamracek created this revision.
Herald added subscribers: kbarton, eraman, javed.absar, nemanjai, sdardis, mehdi_amini.

The `%T` lit expansion expands to a common directory shared between all the tests in the same directory, which is unexpected and unintuitive, and more importantly, it's been a source of subtle race conditions and flaky tests.  In https://reviews.llvm.org/D35396, it was agreed that it would be best to simply ban `%T` and only keep `%t`, which is unique to each test.  When a test needs a temporary directory, it can just create one using `mkdir %t`.

This patch removes `%T` in llvm.


Repository:
  rL LLVM

https://reviews.llvm.org/D36495

Files:
  test/Bindings/OCaml/analysis.ml
  test/Bindings/OCaml/bitreader.ml
  test/Bindings/OCaml/bitwriter.ml
  test/Bindings/OCaml/core.ml
  test/Bindings/OCaml/diagnostic_handler.ml
  test/Bindings/OCaml/executionengine.ml
  test/Bindings/OCaml/ext_exc.ml
  test/Bindings/OCaml/ipo.ml
  test/Bindings/OCaml/irreader.ml
  test/Bindings/OCaml/linker.ml
  test/Bindings/OCaml/passmgr_builder.ml
  test/Bindings/OCaml/scalar_opts.ml
  test/Bindings/OCaml/target.ml
  test/Bindings/OCaml/transform_utils.ml
  test/Bindings/OCaml/vectorize.ml
  test/DebugInfo/PDB/pdbdump-objfilename.yaml
  test/DebugInfo/PDB/pdbdump-source-names.test
  test/DebugInfo/X86/split-dwarf-multiple-cu-hash.ll
  test/DebugInfo/llvm-symbolizer-split-dwarf-empty.test
  test/DebugInfo/llvm-symbolizer.test
  test/ExecutionEngine/RuntimeDyld/AArch64/ELF_ARM64_BE-relocations.s
  test/ExecutionEngine/RuntimeDyld/AArch64/ELF_ARM64_PIC_relocations.s
  test/ExecutionEngine/RuntimeDyld/AArch64/ELF_ARM64_local_branch.s
  test/ExecutionEngine/RuntimeDyld/AArch64/ELF_ARM64_relocations.s
  test/ExecutionEngine/RuntimeDyld/AArch64/MachO_ARM64_relocations.s
  test/ExecutionEngine/RuntimeDyld/ARM/ELF_ARM_EXIDX_relocations.s
  test/ExecutionEngine/RuntimeDyld/ARM/MachO_ARM_PIC_relocations.s
  test/ExecutionEngine/RuntimeDyld/Mips/ELF_Mips64r2N64_PIC_relocations.s
  test/ExecutionEngine/RuntimeDyld/Mips/ELF_N32_relocations.s
  test/ExecutionEngine/RuntimeDyld/Mips/ELF_N64R6_relocations.s
  test/ExecutionEngine/RuntimeDyld/Mips/ELF_O32R6_relocations.s
  test/ExecutionEngine/RuntimeDyld/Mips/ELF_O32_PIC_relocations.s
  test/ExecutionEngine/RuntimeDyld/PowerPC/ppc32_elf_rel_addr16.s
  test/ExecutionEngine/RuntimeDyld/SystemZ/cfi-relo-pc64.s
  test/ExecutionEngine/RuntimeDyld/X86/COFF_x86_64.s
  test/ExecutionEngine/RuntimeDyld/X86/ELF-relaxed.s
  test/ExecutionEngine/RuntimeDyld/X86/ELF_STT_FILE.s
  test/ExecutionEngine/RuntimeDyld/X86/ELF_x64-64_PC8_relocations.s
  test/ExecutionEngine/RuntimeDyld/X86/ELF_x64-64_PIC_relocations.s
  test/ExecutionEngine/RuntimeDyld/X86/ELF_x86-64_PIC-small-relocations.s
  test/ExecutionEngine/RuntimeDyld/X86/ELF_x86-64_debug_frame.s
  test/ExecutionEngine/RuntimeDyld/X86/ELF_x86_64_StubBuf.s
  test/ExecutionEngine/RuntimeDyld/X86/MachO_empty_ehframe.s
  test/ExecutionEngine/RuntimeDyld/X86/MachO_i386_DynNoPIC_relocations.s
  test/ExecutionEngine/RuntimeDyld/X86/MachO_i386_eh_frame.s
  test/ExecutionEngine/RuntimeDyld/X86/MachO_x86-64_PIC_relocations.s
  test/LTO/X86/bcsection.ll
  test/LTO/X86/list-symbols.ll
  test/LibDriver/infer-output-path.test
  test/LibDriver/libpath.test
  test/Object/archive-delete.test
  test/Object/archive-extract.test
  test/Object/archive-move.test
  test/Object/archive-thin-paths.test
  test/Object/archive-update.test
  test/Object/directory.ll
  test/Other/can-execute.txt
  test/Other/lit-globbing.ll
  test/ThinLTO/X86/prefix_replace.ll
  test/Transforms/GCOVProfiling/function-numbering.ll
  test/Transforms/GCOVProfiling/global-ctor.ll
  test/Transforms/GCOVProfiling/linezero.ll
  test/Transforms/GCOVProfiling/linkagename.ll
  test/Transforms/GCOVProfiling/return-block.ll
  test/Transforms/GCOVProfiling/three-element-mdnode.ll
  test/Transforms/GCOVProfiling/version.ll
  test/tools/dsymutil/X86/basic-linking-bundle.test
  test/tools/dsymutil/X86/multiple-inputs.test
  test/tools/gold/X86/bcsection.ll
  test/tools/gold/X86/error-unopenable.ll
  test/tools/gold/X86/thinlto_prefix_replace.ll
  test/tools/llvm-dwp/X86/type_dedup.test
  test/tools/llvm-strings/archive-filename.test
  test/tools/llvm-strings/nested-archives.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D36495.110299.patch
Type: text/x-patch
Size: 86479 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170808/b52cc64a/attachment.bin>