[PATCH] D36477: added more hooks for fuzzing into DFSan
Kostya Serebryany via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 8 15:55:44 PDT 2017
kcc added a comment.
In https://reviews.llvm.org/D36477#836027, @farahhariri wrote:
> In https://reviews.llvm.org/D36477#835621, @kcc wrote:
> > are tests possible here?
> my first thought on testing is that I could add a dummy code that
> has a strcpy call for example, and define dfsan_weak_hook_strcpy
> such that it sets some boolean to true (initially false). And then
> assert that the value is changed to true.
Yep, something of this kind.
> But do you think we should have a test for every single hook?
> like even the already existing ones (which don't have any tests
> as far as I can tell)?
Correct. This is probably my fault. The existing hooks were done as an experiment and later all their uses were removed.
More information about the llvm-commits