[PATCH] D36489: [pdb] Merge PublicsStreamBuilder and GlobalsStreamBuilder

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 8 14:50:45 PDT 2017

rnk added inline comments.

Comment at: lld/COFF/PDB.cpp:644
-    auto &PublicsBuilder = Builder.getPublicsBuilder();
+    auto &PublicsBuilder = Builder.getGsiBuilder();
     for (const PublicSym32 &Pub : Publics)
Rename the local?

Comment at: llvm/lib/DebugInfo/PDB/Native/GSIStreamBuilder.cpp:44
+  uint32_t calculateSerializedLength() const {
+    uint32_t Size = sizeof(GSIHashHeader);
These method bodies are long. We should sink them out of the class definition to reduce indentation.


More information about the llvm-commits mailing list