Windows ASan: Allow 9-byte nops as hotpatch padding

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 8 14:21:29 PDT 2017


Belatedly committed in r310419, thanks for the patch!

On Tue, Jul 25, 2017 at 3:45 PM, David Major via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> This patch makes the 9-byte variant of hint-nop be considered valid
> padding for the hotpatch interception technique.
>
> This is needed in order to safely patch ntdll!strcpy in the Windows 10
> Creators Update, which has a branch target as its fourth byte. With a
> hotpatch we only need to clobber the first two bytes of the function body
> and can leave the branch target intact.
>
> Fixes https://github.com/google/sanitizers/issues/829
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170808/bd01ce10/attachment.html>


More information about the llvm-commits mailing list