[PATCH] D36385: [asan] Refactor thread creation bookkeeping

Roland McGrath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 8 11:58:10 PDT 2017

mcgrathr marked an inline comment as done.
mcgrathr added inline comments.

Comment at: lib/asan/asan_thread.cc:290
+                       const_cast<uptr *>(&stack_size),
+                       &tls_begin_, &tls_size);
   stack_top_ = stack_bottom_ + stack_size;
alekseyshl wrote:
> What was wrong with the wrapping here?
It was over 79 chars, which makes an Emacs in an 80-chars-wide terminal put a \ at the end.
Obviously I don't care about formatting issues, this is just a change I make unconsciously in anything I'm touching.

Comment at: lib/sanitizer_common/sanitizer_thread_registry.cc:255
+// Normally this is called when the thread is about to exit.
+// If aborted is true, then this thread was never really started.
+// We just did CreateThread for a prospective new thread before
alekseyshl wrote:
> What does 'aborted' refer to?
It's left over from a previous version of the change.  I'll update the comment.


More information about the llvm-commits mailing list