[PATCH] D35553: Define OFF_T as 64-bit integer on NetBSD
Vitaly Buka via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 8 11:35:10 PDT 2017
vitalybuka added inline comments.
Comment at: lib/sanitizer_common/sanitizer_internal_defs.h:135
// like pread and mmap, as opposed to pread64 and mmap64.
// FreeBSD, Mac and Linux/x86-64 are special.
+#if SANITIZER_FREEBSD || SANITIZER_NETBSD || SANITIZER_MAC || \
> krytarowski wrote:
> > emaste wrote:
> > > This comment needs to be updated or removed.
> > I've updated it and removed details. I assume that people are well aware about off64_t on Linux.
> @filcab the list of OSes in the comment exactly repeats the following `#if` and adds no value, is there any reason we should repeat them in the comment?
about redundant oses list
More information about the llvm-commits