[PATCH] D36426: [PDB] Fix linking of function symbols and local variables

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

Only one comment, but it does need to be addressed before committing. I'm surprised we don't hit this case anywhere in the LLD test suite. I guess we mostly have C test case inputs, not C++.



================
Comment at: lld/COFF/PDB.cpp:365
+      FuncIdRecord FID =
+          cantFail(TypeDeserializer::deserializeAs<FuncIdRecord>(FuncIdData));
+      *TI = FID.FunctionType;
----------------
This would fail if it were an `LF_MFUNC_ID`


https://reviews.llvm.org/D36426