[PATCH] D35874: [MIPS] Implement support for -mstack-alignment.

Simon Dardis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 8 09:04:14 PDT 2017

sdardis added inline comments.

Comment at: lib/Target/Mips/MipsSubtarget.cpp:167
+  else
+    stackAlignment = 8;
sdardis wrote:
> Can you introduce an assertion here that the ABI is O32? If EABI support is ever brought back or another MIPS abi is introduced, I'd prefer debug builds complain loudly.
That assert needs a && "Unknown ABI for stack alignment!".

Comment at: test/CodeGen/Mips/stack-alignment.ll:11
 ; 64:      addiu  $sp, $sp, -16
+; A32:     addiu  $sp, $sp, -32
This need to be doubled up to A32-32, A32-64 with the appropriate (d)addiu instructions.


More information about the llvm-commits mailing list