[PATCH] D36085: [globalisel][tablegen] Generate TypeObject table. NFC

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 8 08:37:34 PDT 2017


dsanders updated this revision to Diff 110210.
dsanders marked 4 inline comments as done.
dsanders added a comment.

Fixed the priority sort-order nits:

- Returns false if both sides are invalid instead of aborting.
- Avoid checking size-in-bits on separate code-paths and handle it in one place.
- Also order pointers and pointer address spaces since there's no longer an unreachable for them to fall into.


https://reviews.llvm.org/D36085

Files:
  test/TableGen/GlobalISelEmitter.td
  utils/TableGen/GlobalISelEmitter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D36085.110210.patch
Type: text/x-patch
Size: 4293 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170808/67d0a560/attachment.bin>


More information about the llvm-commits mailing list