[PATCH] D36124: [GVN] Remove stale entry in phitranslate cache when new phi is generated for PRE

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 8 08:01:21 PDT 2017

davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.

LGTM, please make sure this doesn't break things as PRE in GVN is quite fragile :)

Comment at: lib/Transforms/Scalar/GVN.cpp:2224
   VN.add(Phi, ValNo);
+  VN.eraseTranslateCacheEntry(ValNo, *CurrentBlock);
   addToLeaderTable(ValNo, Phi, CurrentBlock);
Please add a comment.



More information about the llvm-commits mailing list