[PATCH] D35014: [X86] PR32755 : Improvement in CodeGen instruction selection for LEAs.

[Jatin Bhateja via Phabricator via llvm-commits]

jbhateja added inline comments.


================
Comment at: lib/Target/X86/X86OptimizeLEAs.cpp:258
+  MachineInstr *MI1 = MRI->getVRegDef(MO1.getReg());
+  MachineInstr *MI2 = MRI->getVRegDef(MO2.getReg());
+  if (!MI1 || !MI2)
----------------
lsaba wrote:
> need to check MO2.isReg()
Yes, I shall take care of this.

Kindly let me know if there are any other comments apart from this.

It shall save iterations.


https://reviews.llvm.org/D35014