[PATCH] D35569: [ARM] Remove FeatureNoARM implies ModeThumb.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 8 06:17:19 PDT 2017

fhahn added inline comments.

Comment at: test/CodeGen/ARM/scavenging.mir:2
+# RUN: llc -o - %s -mtriple=thumb-arm-none-eabi -mcpu=cortex-m0 -run-pass scavenger-test | FileCheck %s
 # CHECK-LABEL: name: scavengebug0
rengolin wrote:
> I expect "arm" triple to fail here with an error message like "sorry, no ARM support".
> If that's what happen now, then we should have a negative test, too.
Unfortunately that case isn't covered by this patch and D35627. Those patches only address the issue with `-thumb-mode` in the target features.

After thinking about it for a bit I am not sure we can check the case above unless we are fine breaking cases where the default target triple is arm-....., e.g. that `llc -mcpu=cortex-m0 foo.ll` will fail if the default target triple is an "arm" triple.


More information about the llvm-commits mailing list