[PATCH] D36451: [ELF, LinkerScript] Support ! operator in linker script.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: test/ELF/linkerscript/assert.s:46
+# RUN: FileCheck %s -check-prefix=FAIL1 < %t.log
+# FAIL1: fail
+
----------------
You can reuse `FAIL` I think.

```
# RUN: FileCheck %s -check-prefix=FAIL < %t.log
```


================
Comment at: test/ELF/linkerscript/assert.s:53
+
+
 .section .foo, "a"
----------------
Excessive empty line.


================
Comment at: test/ELF/linkerscript/symbol-assignexpr.s:18
 # RUN:         symbol12 += 1; \
+# RUN:         symbol13 = !(symbol); \
 # RUN:         bar = 0x5678; \
----------------
All your new testcases using parentheses, is there some problem without them ?


https://reviews.llvm.org/D36451