[PATCH] D36440: [ThinLTO] Fix thinLTO crash
David Li via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 7 22:17:00 PDT 2017
davidxl added inline comments.
Comment at: test/Transforms/FunctionImport/funcimport_var.ll:13
+; Function Attrs: nounwind
+declare i32 @link(i8*, i8*) local_unnamed_addr
> Something seems strange to me: the static variable GUID shouldn't be the same as the one here: the static variable name should be prepended with the module name when computing its GUID, shouldn't it?
That is what I thought too, but it is not implemented this way -- see computeVariableSummary and computeFunctionSummary, where summaries are added to the index with the original names.
More information about the llvm-commits