[PATCH] D36434: [compiler-rt] Get rid of "%T" expansions

[Kuba (Brecka) Mracek via Phabricator via llvm-commits]

kubamracek created this revision.
kubamracek added a project: Sanitizers.
Herald added a subscriber: dberris.

The `%T` lit expansion expands to a common directory shared between all the tests in the same directory, which is unexpected and unintuitive, and more importantly, it's been a source of subtle race conditions and flaky tests.  In https://reviews.llvm.org/D35396, it was agreed that it would be best to simply ban `%T` and only keep `%t`, which is unique to each test.  When a test needs a temporary directory, it can just create one using `mkdir %t`.

This patch removes `%T` in compiler-rt.


Repository:
  rL LLVM

https://reviews.llvm.org/D36434

Files:
  test/asan/TestCases/Darwin/dyld_insert_libraries_reexec.cc
  test/asan/TestCases/Darwin/dyld_insert_libraries_remove.cc
  test/asan/TestCases/Darwin/unset-insert-libraries-on-exec.cc
  test/asan/TestCases/Linux/coverage-missing.cc
  test/asan/TestCases/Linux/interception_readdir_r_test.cc
  test/asan/TestCases/Linux/stack-trace-dlclose.cc
  test/asan/TestCases/Posix/asan-symbolize-bad-path.cc
  test/asan/TestCases/Posix/coverage-fork.cc
  test/asan/TestCases/Posix/coverage-reset.cc
  test/asan/TestCases/Posix/coverage.cc
  test/asan/TestCases/Windows/coverage-basic.cc
  test/asan/TestCases/coverage-and-lsan.cc
  test/asan/TestCases/coverage-disabled.cc
  test/asan/TestCases/suppressions-exec-relative-location.cc
  test/asan/TestCases/suppressions-library.cc
  test/asan/TestCases/verbose-log-path_test.cc
  test/asan/lit.cfg
  test/cfi/target_uninstrumented.cpp
  test/msan/coverage-levels.cc
  test/sanitizer_common/TestCases/get_module_and_offset_for_pc.cc
  test/scudo/random_shuffle.cpp
  test/tsan/global_race.cc
  test/tsan/ignore_lib0.cc
  test/tsan/ignore_lib1.cc
  test/tsan/ignore_lib2.cc
  test/tsan/ignore_lib3.cc
  test/tsan/ignore_lib4.cc
  test/tsan/ignore_lib5.cc
  test/tsan/simple_stack2.cc
  test/ubsan/TestCases/Misc/coverage-levels.cc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D36434.110108.patch
Type: text/x-patch
Size: 32807 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170807/62944233/attachment.bin>