[PATCH] D36425: [ZoneAlgo] Allow two writes that write identical values into same array slot

Hongbin Zheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 7 15:55:28 PDT 2017

etherzhhb added inline comments.

Comment at: test/ForwardOpTree/forward_load_double_write.ll:21-22
+      %A_idx = getelementptr inbounds double, double* %A, i32 %j
+      store double %val, double* %A_idx
+      store double %val, double* %A_idx
+      br label %inc
grosser wrote:
> etherzhhb wrote:
> > etherzhhb wrote:
> > > Isn't this could be "canonicalized" by gvn?
> > or dead store elimination
> Maybe then this is a non-optimal test case. In case there are other memory accesses between these two stores, gvn and dead store elimination is often not effective. Clearly, this is not very visible in this simple test case.


More information about the llvm-commits mailing list