[PATCH] D36346: Fix thinlto cache key computation for cfi-icall.

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 7 15:07:54 PDT 2017

eugenis marked an inline comment as done.
eugenis added inline comments.

Comment at: llvm/lib/LTO/LTO.cpp:179
+  auto AddUsedThings = [&](GlobalValueSummary *GS) {
+    for (const ValueInfo &VI : GS->refs())
+      AddUsedCfiGlobal(VI.getGUID());
pcc wrote:
> So GS can't be null here? If so, you can use dyn_cast below.
in fact, it can (but not in the test suite)


More information about the llvm-commits mailing list