[PATCH] D36352: [LCG] Switch one of the update methods for the LazyCallGraph to support limited batch updates.

Sean Silva via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 7 13:06:45 PDT 2017

silvas added a comment.

In https://reviews.llvm.org/D36352#834258, @silvas wrote:

> (it's a ref edge, but if we were to fully inline through GoogleOnceInit it would become a call edge. The actual dispatch to protobuf_AssignDesc_foo_2eproto happens through an external function though so we're saved)

I said "saved" because I was mistakenly thinking that making this a call edge would have a large effect (and forgot to reword before posting), but it actually doesn't since the edges into this mainly come from Foo::GetMetadata (and Bar, Message3) which are only ever called virtually, so there is always a ref edge in the way to prevent the creation of a large CallSCC.


More information about the llvm-commits mailing list