[PATCH] D36386: [clang] Remove unit test which uses reverse-iterate and fix a PointerLikeTypeTrait specialization

Mandeep Singh Grang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 7 12:08:20 PDT 2017

mgrang added a comment.

This patch does 3 things:

1. Get rid of the unit test objc-modern-metadata-visibility2.mm because this test check uses flag -reverse-iterate. This flag will be removed in https://reviews.llvm.org/D35043.

2. https://reviews.llvm.org/D35043 gets rid of the empty base definition for PointerLikeTypeTraits. This results in a compiler warning because PointerLikeTypeTrait has been defined as struct here while in the header it is a class. So I have changed struct to class.

3. Since I changed struct PointerLikeTypeTrait to class PointerLikeTypeTrait here, the member functions are no longer public now. This results in a compiler error. So I explicitly marked them as public here.


More information about the llvm-commits mailing list