[PATCH] D33814: CodeGen: Fix ARM cmpxchg64 register fragmentation in fast-regalloc

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 7 10:44:31 PDT 2017

MatzeB added a comment.

In https://reviews.llvm.org/D33814#834086, @qcolombet wrote:

> Hi,
> The approach sounds sensible to me however, I'd like we use the AllocationPriority instead of the size of the register class.
>  Moreover, please refactor the code (I am thinking helper function) so that the definitions are processed in the same way.
>  Finally, keep the order of the operand as tie breaker.
> Cheers,
> -Quentin
>  PS: If AllocationPriority does not fix the problem, then you'll have to fix the description of the related register class, because size alone is too magic.

The ARM target does not use AllocationPriority yet. Though it would be great to start using it for the GPRPair and tuple classes (in a separate commit though).


More information about the llvm-commits mailing list