[PATCH] D36384: [InstCombine] Support (X | C1) & C2 --> (X & C2^(C1&C2)) | (C1&C2) for vector splats

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombineAndOrXor.cpp:1222
+                                                         Together ^ *C));
+      And->takeName(Op0);
+      return BinaryOperator::CreateOr(And, ConstantInt::get(I.getType(),
----------------
spatel wrote:
> It's not unique to this transform, but I've wondered: are these calls completely eliminated in release builds?
I highly doubt it because release builds should still support tracking names. It's only disabled because the clang driver passes a flag to the cc1 command that disables the name tracking.


https://reviews.llvm.org/D36384