[PATCH] D36405: [AsmParser] Hash is not a comment on some targets

Oliver Stannard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 7 08:59:41 PDT 2017


olista01 created this revision.
Herald added subscribers: kristof.beyls, javed.absar, aemerson.

The '#' token is not a comment for all targets (on ARM and AArch64 it marks an immediate operand), so we shouldn't treat it as such.

Comments are already converted to AsmToken::EndOfStatement by AsmLexer::LexLineComment, so this check was unnecessary.


Repository:
  rL LLVM

https://reviews.llvm.org/D36405

Files:
  lib/MC/MCParser/MCAsmParser.cpp
  test/MC/ARM/directive_parsing.s
  test/MC/AsmParser/AArch64/directive-parse-err.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D36405.110014.patch
Type: text/x-patch
Size: 19907 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170807/684d855b/attachment.bin>


More information about the llvm-commits mailing list