[PATCH] D35945: [ELF] - Linkerscript: better diagnostic for INPUT/GROUP commands.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 7 07:31:59 PDT 2017

grimar added inline comments.

Comment at: ELF/ScriptParser.cpp:280
+  if (ErrorCount)
+    error(">>> location:" + getCurrentLocation());
ruiu wrote:
> I don't think this is enough. You want to check if ErrorCount is incremented in this function.
I think it is not possible to call this function if we have ErrorCount > 0. 
(we call it only from `readAsNeeded()` and `readGroup()` and both check the `ErrorCount` before call)

And also it is not recursive.

I do not know why I would want to check it is incremented. Am I missing something ?


More information about the llvm-commits mailing list