[PATCH] D36307: [Support/GlobPattern] - Treat multiple stars('*') as single.

[George Rimar via Phabricator via llvm-commits]

grimar abandoned this revision.
grimar added a comment.

In https://reviews.llvm.org/D36307#832783, @ruiu wrote:

> I mean, I believe you can still hang this up by passing the following inputs (or something like that, I didn't test this):
>
>   Pattern: a*a*a*a*a*a*a*a*a*a*a*a*a*a*a*a*a*a*a*a*a*a*a*a*a*a*z
>   Input: aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
>   
>
> This is a fundamental limitation of the current algorithm because it's based on backtracking, which is exponential in the worst case. There are better algorithms, but I don't think we need that complexity here. In this test case, you are intentionally trying to break the linker, and it breaks as you wish. You simply shouldn't do that. I don't think we need  to "fix" this.


I see. Closing it. Thanks for looking at this one.


https://reviews.llvm.org/D36307