[PATCH] D36073: [CGP] Extends the scope of optimizeMemoryInst optimization

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 7 00:18:09 PDT 2017


mkazantsev added inline comments.


================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:4630
+    // we find common base later.
+    if (AddrMode.EqualsIgnoreBase(NewAddrMode))
+      // All bases must be of the same type.
----------------
mkazantsev wrote:
> Better use && instread of increased nesting.
UPD: Not viable here, sorry, I misread it.


https://reviews.llvm.org/D36073





More information about the llvm-commits mailing list