[PATCH] D36377: Add NetBSD support in asan_stack.h

Kamil Rytarowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 6 18:07:01 PDT 2017


krytarowski added a comment.

In https://reviews.llvm.org/D36377#833523, @davide wrote:

> Kamil, a fair amount of these changes seem to just replace `SANITIZER_FREEBSD` with `SANITIZER_FREEBSD || SANITIZER_NETBSD`.
>  I wonder whether it makes sense to define a `SANITIZER_BSD` macro for both of them?
>
> Also, what's the difference in support you expect between NetBSD and FreeBSD to support sanitizers?


I oppose SANITIZER_BSD as I don't intend to test BSD/OS and similar systems.

FreeBSD and NetBSD are sufficiently distinct to be managed separately. Also there will certainly come at some point OpenBSD, which
is different than FreeBSD and NetBSD. I don't have access to other BSDs to test potential patches.

Solaris support as far as I recall, was very similar, mostly adding `|| SANITIZER_SOLARIS` to existing code.


Repository:
  rL LLVM

https://reviews.llvm.org/D36377





More information about the llvm-commits mailing list