[PATCH] D36331: Add ARC backend

[Eugene Zelenko via Phabricator via llvm-commits]

Eugene.Zelenko added inline comments.


================
Comment at: llvm/lib/Target/ARC/ARC.h:31
+FunctionPass *createARCBranchFinalizePass();
+} // namespace llvm
+
----------------
I think will be good idea to make namespace formatting uniform across files. It looks better when empty line separate namespace beginning and end. //end namspace XYZ// and //end anonymous namespace// are predominant closing comments in LLVM.


================
Comment at: llvm/lib/Target/ARC/ARCBranchFinalize.cpp:1
+//===--- ARCBranchFinalize.cpp - ARC conditional branches ---*- C++ -*-===//
+// Copyright 2017-present Synopsys, Inc.
----------------
Please make sure that such comment lines are 80 characters wide. It will be better to use only one dash (//===-) at beginning.


================
Comment at: llvm/lib/Target/ARC/ARCBranchFinalize.cpp:28
+#include <vector>
+
+using namespace llvm;
----------------
Unnecessary empty line.


================
Comment at: llvm/lib/Target/ARC/ARCBranchFinalize.cpp:40
+  static char ID;
+  ARCBranchFinalize() : MachineFunctionPass(ID) {
+    initializeARCBranchFinalizePass(*PassRegistry::getPassRegistry());
----------------
Please add empty line before and after constructor body. Also after getPassName()


================
Comment at: llvm/lib/Target/ARC/ARCISelDAGToDAG.cpp:39
+/// instructions for SelectionDAG operations.
+///
+namespace {
----------------
Unnecessary empty comment.


https://reviews.llvm.org/D36331