[PATCH] D33880: COFF: Introduce LD shim around LINK

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 5 13:11:39 PDT 2017


mstorsjo added inline comments.


================
Comment at: MinGW/Driver.cpp:212
+  forwardValue(Args, OPT_m, "i386pep", "MACHINE", "X64");
+  forwardValue(Args, OPT_m, "thumb2pe", "MACHINE", "ARM");
+
----------------
As I got the mingw-arm64 stuff complete enough to publish patches now and this isn't merged yet, you could add a mapping from `arm64pe` (or whatever we choose in D36364) to `ARM64` here.


================
Comment at: tools/lld/lld.cpp:57
+    StringRef S = *(It + 1);
+    return S == "i386pe" || S == "i386pep" || S == "thumb2pe";
+  }
----------------
... and here, and in `ELF/Driver.cpp`


Repository:
  rL LLVM

https://reviews.llvm.org/D33880





More information about the llvm-commits mailing list