[PATCH] D36350: [lld] Allow rel iplt symbols with dynamic symbol table

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 4 21:56:48 PDT 2017


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: test/ELF/gnu-ifunc-dynsym.s:7
+// CHECK-DAG: __rela_iplt_start
+// CHECK-DAG: __rela_iplt_end
+
----------------
smeenai wrote:
> smeenai wrote:
> > ruiu wrote:
> > > Remove -DAG?
> > I had the `-DAG` because I don't care about the order in which the symbols appear, only that they're both present. I'm happy without it as well though.
> To clarify, I meant their order in the `llvm-nm` output. Of course the end symbol should be after the start symbol in terms of addresses, but llvm-nm appears to print out symbols in reverse order of addresses, at least in this instance.
Ah, I didn't actually know that FileCheck had such feature.


https://reviews.llvm.org/D36350





More information about the llvm-commits mailing list