[PATCH] D35985: Skip live range segment verification for reserved physregs

[Matthias Braun via Phabricator via llvm-commits]

MatzeB requested changes to this revision.
MatzeB added a comment.
This revision now requires changes to proceed.

I would expect the live ranges of register units that are reserved to be empty and therefore naturally pass verification. Do you know why you end up having non-empty information in those live ranges? We should identify the cause for that and fix it.



================
Comment at: lib/CodeGen/MachineVerifier.cpp:1788-1792
+  if(TargetRegisterInfo::isPhysicalRegister(Reg)) {
+    MCRegUnitRootIterator Roots(Reg, TRI);
+    if(isReserved(*Roots))
+      return;
+  }
----------------
This makes no sense: `MCRegUnitRootIterator` takes a register unit argument, you are passing a (plain) register instead.


https://reviews.llvm.org/D35985