[PATCH] D36197: [X86] Teach fastisel to select calls to dllimport functions

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 4 15:40:55 PDT 2017

Previous message: [PATCH] D36197: [X86] Teach fastisel to select calls to dllimport functions
Next message: [PATCH] D36197: [X86] Teach fastisel to select calls to dllimport functions
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.

In general looks ok. Mind commenting the if(NeedLoad) areas as to what you're adding on and why? The symbol is (IMO) obvious, but the random bits less so.

Thanks!


https://reviews.llvm.org/D36197

Previous message: [PATCH] D36197: [X86] Teach fastisel to select calls to dllimport functions
Next message: [PATCH] D36197: [X86] Teach fastisel to select calls to dllimport functions
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list