[PATCH] D35844: Correct dwarf unwind information in function epilogue

Kyle Butt via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 4 13:16:29 PDT 2017


iteratee added inline comments.


================
Comment at: include/llvm/CodeGen/MachineBasicBlock.h:781
+  // block's entry. It is added to IncomingCFAOffset in CFIInfoVerifier.
+  int AdjustIncomingCFAOffset = 0;
+  // Amount used for adjusting the value of outgoing cfa offset. This value
----------------
I don't follow the comment about why these are necessary again.
Can you elaborate?


================
Comment at: lib/CodeGen/TargetPassConfig.cpp:772
 
+  // Verify basic block incoming and outgoing cfa offset and register values.
+  addPass(createCFIInfoVerifier());
----------------
I thought part of the problem was that these passes should not be run generally.


Repository:
  rL LLVM

https://reviews.llvm.org/D35844





More information about the llvm-commits mailing list