[PATCH] D36333: Move the SampleProfileLoader right after EarlyFPM.

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: lib/Passes/PassBuilder.cpp:558
+    if (Phase != ThinLTOPhase::PreLink)
+      // During the ThinLTO backend phase we perform early indirect call
+      // promotion here, before globalopt. Otherwise imported
----------------
PGO ICP is called here for both the ThinLTO backend and the non-ThinLTO sample PGO case, right? If so, perhaps the comment should be modified slightly to "We perform early indirect call promotion here, before globalopt. This is important for the ThinLTO backend phase because otherwise imported..."


================
Comment at: test/Other/new-pm-thinlto-defaults.ll:56
 ; CHECK-DIS-NEXT: Running analysis: InnerAnalysisManagerProxy
-; CHECK-POSTLINK-O-NEXT: Running pass: PGOIndirectCallPromotion
-; CHECK-POSTLINK-O-NEXT: Running analysis: InnerAnalysisManagerProxy<{{.*}}Function
----------------
Where did this one go?


https://reviews.llvm.org/D36333