[PATCH] D36334: [lld] Write the PDB absolute path to the debug directory header

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: lld/COFF/Writer.cpp:81
 class CVDebugRecordChunk : public Chunk {
+  SmallString<128> PDBAbsPath;
+
----------------
Can we group this at the end with the other fields? That's more consistent with the rest of LLD, access labels be damned.


================
Comment at: lld/COFF/Writer.cpp:83
+
   size_t getSize() const override {
+    return sizeof(codeview::DebugInfo) + PDBAbsPath.size() + 1;
----------------
How about moving the `public:` label up here, since these are method overrides, so they are actually public.


https://reviews.llvm.org/D36334