[PATCH] D36270: [llvm-dwarfdump] - Change how dwarfdump dumps .debug_ranges

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

Thanks for explanations and testcase, David !
My comments below.

In https://reviews.llvm.org/D36270#830831, @dblaikie wrote:

> A couple of things
>
> 1. If possible, I think it'd be better if it printed the section name, rather than the section index


Then I believe we want to print both name and index, because there can be multiple sections with the same name:
.section .foo, "aw", @progbits, unique, 1
.section .foo, "aw", @init_array, unique, 2
.section .foo, "aw", @preinit_array, unique, 3

> How does your patch deal with handling the default base address? Given that it varies between each range list in debug_ranges and would only be known by determining which CU refers to that range list (which can only be known by walking all the DWARF DIEs to find the points that refer to range lists)? Does it not use a default base address? (I guess that's not the case) Does it use the default base address of the first CU?
> 
> I'd say probably leave the debug_ranges dumping as-is (I think there's a minor change that could be made to improve it a little*, but still leave it basically dumping the raw bytes, not the processed/semantic range list) but improve the range dumping in debug_info to include this info, perhaps?

You right, this patch does not know about default base address, it works only with addess selection entries if there are any. I think I'll abandon it and try to improve .debug_info dumping just like you suggested.


https://reviews.llvm.org/D36270