[PATCH] D36260: [ARM] Use searchable-table for banked registers

Javed Absar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 3 20:38:18 PDT 2017


javed.absar marked an inline comment as done.
javed.absar added inline comments.


================
Comment at: lib/Target/ARM/InstPrinter/ARMInstPrinter.cpp:886
+  uint32_t R = (Banked & 0x20) >> 5;
+  if (R)
+    name.replace(0, 4, "SPSR"); // convert 'spsr_' to 'SPSR_'
----------------
fhahn wrote:
> can we just use an assert here and get rid of the `if`?
I don't see how that would work since its just a conditional action and not a constraint


https://reviews.llvm.org/D36260





More information about the llvm-commits mailing list