[PATCH] D35865: [asan] Fuchsia port

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: lib/asan/asan_errors.cc:74
+#if SANITIZER_FUCHSIA
+  UNIMPLEMENTED();
+#else
----------------
Why you can't leave the current implementation?


================
Comment at: lib/asan/asan_rtl.cc:370
 
+#if !SANITIZER_FUCHSIA
+AsanThread *CreateMainThread() {
----------------
Please move into CL with thread API refactoring as well


================
Comment at: lib/asan/asan_shadow_setup.cc:17
+
+// asan_fuchsia.cc has its own InitializeShadowMemory implementation.
+#if !SANITIZER_FUCHSIA
----------------
Can I ask you to try later to move such full file "#if !SANITIZER_FUCHSIA ..." into cmake rules?


================
Comment at: lib/asan/asan_thread.cc:273
+  if (SANITIZER_FUCHSIA) {
+    // On Fuchsia, Init() is called (and calls here) in the creator thread
+    // before the new thread is actually started, but its stack address range
----------------
Please move API change and other thread code movements, without fucshia, into separate patch



================
Comment at: lib/asan/asan_thread.cc:281
+    CHECK_NE(init_stack_size, 0);
+    stack_bottom_ = init_stack_bottom;
+    stack_top_ = init_stack_bottom + init_stack_size;
----------------
Could you please put fuchsia version 
void AsanThread::SetThreadStackAndTls()  into asan_fuchsia 


https://reviews.llvm.org/D35865