[PATCH] D36233: [ThinLTO] Add FunctionAttrs to ThinLTO index

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 3 16:45:32 PDT 2017


mehdi_amini added inline comments.


================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:5118
+        RefListStartIndex = 5;
+      }
+
----------------
tejohnson wrote:
> mehdi_amini wrote:
> > Note: for these we don't usually use a version, we just look at the size of the Record.
> I don't think that will work since we have a variable number of reference and call edge records following the flags. We have the number of references (NumRefs) but not the number of calls. That is deduced from the length of the record.
Yes you're right.
(I had only looked at the code above here)


https://reviews.llvm.org/D36233





More information about the llvm-commits mailing list