[PATCH] D34048: [PowerPC] Eliminate compares - add i32 sext/zext handling for SETLE/SETGE

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 3 13:29:32 PDT 2017


echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.

One inline comment, otherwise lgtm.

-eric



================
Comment at: lib/Target/PowerPC/PPCISelDAGToDAG.cpp:2913
+      return getCompoundZeroComparisonInGPR(LHS, dl, ZeroCompare::GEZExt);
+    std::swap(LHS, RHS);
+    ConstantSDNode *RHSConst = dyn_cast<ConstantSDNode>(RHS);
----------------
Comment on these that we're going to swap and fallthrough?


Repository:
  rL LLVM

https://reviews.llvm.org/D34048





More information about the llvm-commits mailing list