[PATCH] D36276: [zorg] Remove test_polly_format step from Polly buildbot

[Pengxuan Zheng via Phabricator via llvm-commits]

pzheng created this revision.
Herald added a reviewer: bollu.

The test_polly_format does "make polly-check-format" which is already covered by
the "make check-polly" step.


https://reviews.llvm.org/D36276

Files:
  buildbot/osuosl/master/config/builders.py
  zorg/buildbot/builders/AOSPBuilder.py
  zorg/buildbot/builders/PollyBuilder.py


Index: zorg/buildbot/builders/PollyBuilder.py
===================================================================
--- zorg/buildbot/builders/PollyBuilder.py
+++ zorg/buildbot/builders/PollyBuilder.py
@@ -14,7 +14,6 @@
     install=False,
     make='make',
     jobs=None,
-    checkFormat=True,
     extraCmakeArgs=[]):
     llvm_srcdir = "llvm.src"
     llvm_objdir = "llvm.obj"
@@ -27,7 +26,6 @@
     build_cmd = [make] + jobs_cmd
     install_cmd = [make, 'install'] + jobs_cmd
     check_cmd = [make, 'check-polly'] + jobs_cmd
-    check_format_cmd = [make, 'polly-check-format'] + jobs_cmd
     cmake_install = []
     if install:
         cmake_install = ["-DCMAKE_INSTALL_PREFIX=../%s" % llvm_instdir]
@@ -106,17 +104,10 @@
     # Test Polly
     f.addStep(ShellCommand(name="test_polly",
                            command=check_cmd,
-                           haltOnFailure=True,
+                           haltOnFailure=False,
                            description=["test polly"],
                            workdir=llvm_objdir))
 
-    # Check formatting
-    if checkFormat:
-        f.addStep(ShellCommand(name="test_polly_format",
-                               command=check_format_cmd,
-                               haltOnFailure=False,
-                               description=["check formatting"],
-                               workdir=llvm_objdir))
     return f
 
 def AddExternalPollyBuildFactory(f, llvm_installdir, build_type = "Release"):
Index: zorg/buildbot/builders/AOSPBuilder.py
===================================================================
--- zorg/buildbot/builders/AOSPBuilder.py
+++ zorg/buildbot/builders/AOSPBuilder.py
@@ -68,7 +68,6 @@
                                               install=True,
                                               make='ninja',
                                               jobs=jobs,
-                                              checkFormat=False,
                                               extraCmakeArgs=extra_cmake_args)
         clang_dir = 'llvm.inst/bin'
 
Index: buildbot/osuosl/master/config/builders.py
===================================================================
--- buildbot/osuosl/master/config/builders.py
+++ buildbot/osuosl/master/config/builders.py
@@ -803,7 +803,6 @@
                 install=True,
                 make='ninja',
                 jobs=16,
-                checkFormat=False,
                 extraCmakeArgs=["-G", "Ninja",
                                 "-DLLVM_TARGETS_TO_BUILD='ARM;AArch64'",
                                 "-DLLVM_DEFAULT_TARGET_TRIPLE=arm-linux-gnueabi",


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D36276.109600.patch
Type: text/x-patch
Size: 2615 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170803/35ba989a/attachment.bin>