[llvm] r309967 - Fix check-lit compatibility with multi-config CMake generators

[Greg Bedwell via llvm-commits]

Author: gbedwell
Date: Thu Aug  3 10:55:54 2017
New Revision: 309967

URL: http://llvm.org/viewvc/llvm-project?rev=309967&view=rev
Log:
Fix check-lit compatibility with multi-config CMake generators

Multi-configuration CMake generators such as those for Visual Studio or Xcode do not
specify a build config at configure time, but let the user choose at build
time.  In these cases binaries go into build/${Configuration}/bin rather than
build/bin.  Prior to this commit, check-lit would fail when using multi-configuration
generators as it did not know how to resolve ${Configuration} in order
to find tools such as FileCheck.  This commit teaches it to resolve
llvm_tools_dir within lit using the value specified with --param
build_mode.

Differential Revision: https://reviews.llvm.org/D36263

Modified:
    llvm/trunk/utils/lit/CMakeLists.txt
    llvm/trunk/utils/lit/tests/lit.site.cfg.in

Modified: llvm/trunk/utils/lit/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/CMakeLists.txt?rev=309967&r1=309966&r2=309967&view=diff
==============================================================================
--- llvm/trunk/utils/lit/CMakeLists.txt (original)
+++ llvm/trunk/utils/lit/CMakeLists.txt Thu Aug  3 10:55:54 2017
@@ -1,7 +1,7 @@
 # The configured file is not placed in the correct location
 # until the tests are run as we need to copy it into
 # a copy of the tests folder
-configure_file("tests/lit.site.cfg.in" "lit.site.cfg" @ONLY)
+configure_lit_site_cfg("tests/lit.site.cfg.in" "lit.site.cfg")
 
 # Lit's test suite creates output files next to the sources which makes the
 # source tree dirty. This is undesirable because we do out of source builds.

Modified: llvm/trunk/utils/lit/tests/lit.site.cfg.in
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/tests/lit.site.cfg.in?rev=309967&r1=309966&r2=309967&view=diff
==============================================================================
--- llvm/trunk/utils/lit/tests/lit.site.cfg.in (original)
+++ llvm/trunk/utils/lit/tests/lit.site.cfg.in Thu Aug  3 10:55:54 2017
@@ -1,8 +1,19 @@
-## Autogenerated by LLVM/Clang configuration.
-# Do not edit!
+ at LIT_SITE_CFG_IN_HEADER@
+
+import sys
+
 config.llvm_src_root = "@LLVM_SOURCE_DIR@"
 config.llvm_obj_root = "@LLVM_BINARY_DIR@"
-config.llvm_tools_dir = "@LLVM_TOOLS_BINARY_DIR@"
+config.llvm_tools_dir = "@LLVM_TOOLS_DIR@"
+
+# Support substitution of the tools_dir with user parameters.
+# This is used when we can't determine the tool dir at configuration time.
+try:
+    config.llvm_tools_dir = config.llvm_tools_dir % lit_config.params
+except KeyError:
+    e = sys.exc_info()[1]
+    key, = e.args
+    lit_config.fatal("unable to find %r parameter, use '--param=%s=VALUE'" % (key,key))
 
 # Let the main config do the real work.
 lit_config.load_config(config, "@LLVM_BINARY_DIR@/utils/lit/tests/lit.cfg")