[PATCH] D35621: X86 Asm can't work properly with symbolic Scale

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 3 10:27:47 PDT 2017


RKSimon added inline comments.


================
Comment at: lib/Target/X86/AsmParser/X86AsmParser.cpp:1596
+    Disp = Imm; // It can be an immediate displacement only (maybe 0).
   }
 
----------------
What is this accomplishing? Pulling on ImmVal makes sense, but the rest looks wrong - for instance, if Disp is a MCExpr::Constant doesn't that constant value is overriden by Imm instead of being added together?


https://reviews.llvm.org/D35621





More information about the llvm-commits mailing list