[llvm] r309821 - [AArch64] Simplify AES*Tied pseudo expansion (NFC).

Florian Hahn via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 3 10:15:22 PDT 2017


Hi Tim,

On 03/08/2017 18:01, Tim Northover wrote:
> Hi Florian,
> 
> On 2 August 2017 at 08:17, Florian Hahn via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>> [AArch64] Simplify AES*Tied pseudo expansion (NFC).
>>
>> Summary:
>> Suggested by @t.p.northover in https://bugs.llvm.org/show_bug.cgi?id=34015.
> 
> Sorry about this, but it seems I was wrong. If we just call setDesc
> then the MachineOperands are still tied and the verifier gets confused
> (leading to at least one Green Dragon failure). I couldn't find a
> simple way to untie them so I've just reverted this in r309962.
> 
> I don't think there's any need for a followup to reapply this, it was
> a peephole change anyway really.
>

Thanks for taking care of that! I noticed the same thing today. I was 
thinking about either removing the tied flags from the operands, but I 
didn't have time to try that yet.

Cheers,
Florian


More information about the llvm-commits mailing list