[PATCH] D35672: [XRay] [test-suite] Don't use llvm_multisource macro for XRay tests and use .test files
Matthias Braun via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 3 10:07:10 PDT 2017
MatzeB accepted this revision.
MatzeB added a comment.
LGTM
================
Comment at: MicroBenchmarks/XRay/CMakeLists.txt:7
list(APPEND LDFLAGS -fxray-instrument)
- set(RUN_OPTIONS --benchmark_repetitions=10 --benchmark_report_aggregates_only=true)
-
- set(PROG retref-bench)
- llvm_multisource()
+ llvm_test_run(--benchmark_filter=dummy_skip_ignore)
+ llvm_test_executable(retref-bench retref-bench.cc)
----------------
I'm surprised you had to put `llvm_test_run` here. I assume you were getting errors otherwise, so it's fine to move forward with the patch as is. I'll investigate why this couldn't be left out separately.
https://reviews.llvm.org/D35672
More information about the llvm-commits
mailing list