[PATCH] D36233: [ThinLTO] Add FunctionAttrs to ThinLTO index

Charles Saternos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 3 09:45:25 PDT 2017


ncharlie added a comment.

> Note the function is dumped with "noalias", but doesn't have the NoAlias attribute. However, the return is marked no alias. And looking at the FunctionAttrs.cpp NoAlias propagation (addNoAliasAttrs), it is this (the returnDoesNotAlias) that is being propagated. So perhaps that's what you need to be checking. Probably change the name of the boolean flag in the index accordingly.

Ah, now it makes sense why the it was still propagating the alias attribute even though that NoAlias flag wasn't set. I'll correct my patch.


https://reviews.llvm.org/D36233





More information about the llvm-commits mailing list