[PATCH] D35936: [ELF] - Move getSymbols() methods to InputFile.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 3 04:47:23 PDT 2017


ruiu added inline comments.


================
Comment at: ELF/OutputSections.cpp:433
   ObjFile<ELFT> *Obj = Sections[0]->getFile<ELFT>();
-  ArrayRef<SymbolBody *> Symbols = Obj->getSymbols();
+  ArrayRef<SymbolBody *> Symbols = Obj->getSymbols().drop_front();
   OS->Info = InX::SymTab->getSymbolIndex(Symbols[Sections[0]->Info - 1]);
----------------
This change is dubious and shouldn't be here.


https://reviews.llvm.org/D35936





More information about the llvm-commits mailing list