[PATCH] D36263: [lit] check-lit compatibility with multi-config CMake generators

[Greg Bedwell via Phabricator via llvm-commits]

gbedwell created this revision.

> 
> 
>   Multi-configuration CMake generators such as Visual Studio or Xcode do not
>   specify a build config at configure time, but let the user choose at build
>   time.  In these cases binaries go into bin/${Configuration} rather than
>   bin/.  Prior to this commit, check-lit would fail when using multi-configuration
>   generators as it did not know how to resolve bin/${Configuration} in order
>   to find tools such as FileCheck.  This commit teaches it to resolve
>   llvm_tools_dir at within lit using the value specified with --param
>   build_mode.
>    

This commit supersedes https://reviews.llvm.org/D36212 after discussion in that review.  Essentially we're just using the strategy seen elsewhere to deal with this issue (e.g. llvm/test/Unit )


https://reviews.llvm.org/D36263

Files:
  utils/lit/CMakeLists.txt
  utils/lit/tests/lit.site.cfg.in


Index: utils/lit/tests/lit.site.cfg.in
===================================================================
--- utils/lit/tests/lit.site.cfg.in
+++ utils/lit/tests/lit.site.cfg.in
@@ -1,8 +1,19 @@
-## Autogenerated by LLVM/Clang configuration.
-# Do not edit!
+ at LIT_SITE_CFG_IN_HEADER@
+
+import sys
+
 config.llvm_src_root = "@LLVM_SOURCE_DIR@"
 config.llvm_obj_root = "@LLVM_BINARY_DIR@"
-config.llvm_tools_dir = "@LLVM_TOOLS_BINARY_DIR@"
+config.llvm_tools_dir = "@LLVM_TOOLS_DIR@"
+
+# Support substitution of the tools_dir with user parameters.
+# This is used when we can't determine the tool dir at configuration time.
+try:
+    config.llvm_tools_dir = config.llvm_tools_dir % lit_config.params
+except KeyError:
+    e = sys.exc_info()[1]
+    key, = e.args
+    lit_config.fatal("unable to find %r parameter, use '--param=%s=VALUE'" % (key,key))
 
 # Let the main config do the real work.
 lit_config.load_config(config, "@LLVM_BINARY_DIR@/utils/lit/tests/lit.cfg")
Index: utils/lit/CMakeLists.txt
===================================================================
--- utils/lit/CMakeLists.txt
+++ utils/lit/CMakeLists.txt
@@ -1,7 +1,7 @@
 # The configured file is not placed in the correct location
 # until the tests are run as we need to copy it into
 # a copy of the tests folder
-configure_file("tests/lit.site.cfg.in" "lit.site.cfg" @ONLY)
+configure_lit_site_cfg("tests/lit.site.cfg.in" "lit.site.cfg")
 
 # Lit's test suite creates output files next to the sources which makes the
 # source tree dirty. This is undesirable because we do out of source builds.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D36263.109516.patch
Type: text/x-patch
Size: 1577 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170803/e8e24493/attachment.bin>