[PATCH] D29826: [SLP] General improvements of SLP vectorization process.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

Does anyone else have any comments?



================
Comment at: test/Transforms/SLPVectorizer/X86/horizontal.ll:834
+; CHECK-NEXT:    [[TMP1:%.*]] = extractelement <8 x i32> [[BIN_RDX4]], i32 0
+; CHECK-NEXT:    [[ADD_6:%.*]] = add nsw i32 undef, [[ADD_5]]
+; CHECK-NEXT:    [[RES:%.*]] = call i32 @foobar(i32 [[TMP1]])
----------------
It's a bit annoying that the old scalar reduction hasn't completely disappeared.


================
Comment at: test/Transforms/SLPVectorizer/X86/horizontal.ll:876
+; CHECK-NEXT:    [[ADD_6:%.*]] = add nsw i32 undef, [[ADD_5]]
+; CHECK-NEXT:    [[RES:%.*]] = invoke i32 @foobar(i32 [[TMP1]])
 ; CHECK-NEXT:    to label [[NORMAL:%.*]] unwind label [[EXCEPTION:%.*]]
----------------
It's a bit annoying that the old scalar reduction hasn't completely disappeared.


https://reviews.llvm.org/D29826