[PATCH] D36258: Disable loop peeling during full unrolling pass.

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 2 23:03:47 PDT 2017


davidxl added inline comments.


================
Comment at: lib/Transforms/Scalar/LoopUnrollPass.cpp:204
     UP.UpperBound = *UserUpperBound;
+  if (UserAllowPeeling.hasValue())
+    UP.AllowPeeling = *UserAllowPeeling;
----------------
chandlerc wrote:
> davidxl wrote:
> > Move this closer to line 188 above?
> I think this location is more consistent with the surrounding code... I'm reluctant to deviate here from what seems like a very consistent pattern.
Right. They all should be interleaved so that settings to the same flag should be side by side, but that is not relevant here.


https://reviews.llvm.org/D36258





More information about the llvm-commits mailing list