[PATCH] D36107: [PostDom] document the current handling of infinite loops and unreachables

[Jakub (Kuba) Kuderski via llvm-commits]

Thanks. Can you also fix that above DeletingEdgesIntroducesInfiniteLoop2? Best,
Kuba

On Wed, Aug 2, 2017 at 9:19 PM, Tobias Grosser <tobias.grosser at inf.ethz.ch>
wrote:

> On Thu, Aug 3, 2017, at 06:12, Tobias Grosser via llvm-commits wrote:
> > On Thu, Aug 3, 2017, at 02:19, Jakub Kuderski via Phabricator via
> > llvm-commits wrote:
> > > kuhar added a comment.
> > >
> > > I've just realized that I didn't notice the TODOs  in this patch when I
> > > did a code review for it.
> > >
> > >   // TODO: Can we change the PDT definition such that C remains part of
> > >   the
> > >   //       CFG, at best without loosing the dominance relation D
> postdom
> > >   B.
> > >
> > > I don't think we reached an agreement on the second part of the TODO,
> as
> > > the `"at best"` might imply. Could you reword the second part of the
> > > comment to be less ambiguous and not to suggest that?
> >
> > I can just drop it.There is no need to sneak in TODOs to reach an
> > agreement.
> > Hopefully our discussion is fruit
> >
> > > And a very minor nitpick: isn't it supposed to be s/loosing/losing? :)
>
> r309919
>
> Best,
> Tobias
> >
> > Best,
> > Tobias
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>



-- 
Jakub Kuderski
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170802/34f4882b/attachment.html>